RFR: 8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry [v2]

[Chen Liang]

On Thu, 14 Nov 2024 17:02:49 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Class-File API usually expose names in a form of `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately `java.lang.classfile.Attribute::attributeName` method was omitted during the API review and it returns inflated `String` value of the name.
>> 
>> This patch changes return type of `java.lang.classfile.Attribute::attributeName` from `String` to `java.lang.classfile.constantpool.Utf8Entry`.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fixed tests

test/langtools/tools/javap/T6716452.java line 73:

> 71:                     error(mm + ": unexpected attribute found,"
> 72:                             + " expected " + c.getName()
> 73:                             + " found " + mm.attributes().get(index).attributeName());

Is this one redundant?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22107#discussion_r1842600288