RFR: 8343125: Correct the documentation for TreeMap's getFloorEntry and getCeilingEntry [v3]
Archie Cobbs
acobbs at openjdk.org
Thu Nov 14 18:10:45 UTC 2024
On Thu, 14 Nov 2024 03:23:29 GMT, Naman Nigam <duke at openjdk.org> wrote:
>> As the documentation of getCeilingEntry currently reads, the inference is misleading as follows:
>>
>> if no such entry exists, returns the entry for the least key greater than the specified key;
>> if no such entry exists (i.e., the greatest key in the Tree is less than the specified key), returns {@code null}
>> Have modified the first section to ensure that its clear that the value returned is upon existence of the key. Added a similar change for getFloorEntry.
>
> Naman Nigam has updated the pull request incrementally with one additional commit since the last revision:
>
> JDK-8343125 : Empty tree case explicitly specified.
Looks good to me too.
-------------
Marked as reviewed by acobbs (Committer).
PR Review: https://git.openjdk.org/jdk/pull/21729#pullrequestreview-2436852730
More information about the core-libs-dev
mailing list