RFR: 8344179: SecurityManager cleanup in the ZIP and JAR areas [v2]

[Sean Mullan]

On Thu, 14 Nov 2024 19:58:21 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> As long as the line in your ide is  around 80 characters or less you are good to go.  If it is say 100 bytes so you have to scroll, that is when I would fold the line.
>> 
>> I think you are OK here
>
> Yes, they are 96 and 98 chars long, which means I sympathise with both views :)
> 
> Unless hearing back from @seanjmullan I'll go with Roger's suggestion of one line here.

I think both are in the 90-100 range. Line length is a bit subjective, but I know that at least in the Security Group, we try to keep code to around 80 chars so it is easy to review in a side-by-side diff. It also is visually easier to read I think. In these cases, when breaking, I think it makes sense to break after the `=`. The other option is to make the variable names smaller.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22099#discussion_r1842819047