RFR: 8344252: SM cleanup in java.util classes

Naoto Sato naoto at openjdk.org
Thu Nov 14 22:48:16 UTC 2024


On Thu, 14 Nov 2024 22:09:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

> Remove use of doPrivileged and SecurityManager in java.util.

src/java.base/share/classes/java/util/Properties.java line 952:

> 950: 
> 951:     private static void writeDateComment(BufferedWriter bw) throws IOException {
> 952:         // value of java.properties.date system property isn't sensitive

Left over comment?

src/java.base/share/classes/java/util/ResourceBundle.java line 1889:

> 1887:                 return s;
> 1888:             }
> 1889:         } catch (ClassNotFoundException e) {}

Suggestion:

        } catch (ClassNotFoundException _) {}

src/java.base/share/classes/java/util/spi/AbstractResourceBundleProvider.java line 82:

> 80:  *
> 81:  * @see <a href="../ResourceBundle.html#resource-bundle-modules">
> 82:  * Resource Bundles and Named Modules</a>

Could be replaced with 

ResourceBundle##resource-bundle-modules
    Resource Bundles and Named Modules

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842966914
PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842977529
PR Review Comment: https://git.openjdk.org/jdk/pull/22122#discussion_r1842974477


More information about the core-libs-dev mailing list