RFR: 8344259: Annotate Float16 with jdk.internal.ValueBased
Joe Darcy
darcy at openjdk.org
Fri Nov 15 01:04:49 UTC 2024
On Fri, 15 Nov 2024 00:25:20 GMT, Paul Sandoz <psandoz at openjdk.org> wrote:
> Annotate `Float16` with `jdk.internal.ValueBased`. This requires we export the package `jdk.internal` in module `java.base` to module` jdk.incubator.vector`.
>
> Doing so enables the compiler and runtime to report warnings about improper attempts to synchronize on instances of `Float16`, as described in [JEP 390](https://openjdk.org/jeps/390).
Looks fine; please manually verify the expected javac warnings are given for misuse of Float16 in non-value ways.
-------------
Marked as reviewed by darcy (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/22128#pullrequestreview-2437474278
More information about the core-libs-dev
mailing list