RFR: 8344168: Change Unsafe base offset from int to long [v2]

Shaojin Wen swen at openjdk.org
Fri Nov 15 01:04:58 UTC 2024


> The type of the Unsafe base offset constant is int, which may cause overflow when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are still unfixed.
> 
> @liach proposed the idea of ​​changing the Unsafe base offset to long, which is a complete solution to the Unsafe offset overflow. After discussing with @liach, I submitted this PR to implement @liach's idea.

Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:

  long BaseAndScale base, from @JornVernee

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22095/files
  - new: https://git.openjdk.org/jdk/pull/22095/files/c0c283ef..f33e9d3d

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22095&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22095&range=00-01

  Stats: 9 lines in 2 files changed: 0 ins; 0 del; 9 mod
  Patch: https://git.openjdk.org/jdk/pull/22095.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22095/head:pull/22095

PR: https://git.openjdk.org/jdk/pull/22095


More information about the core-libs-dev mailing list