RFR: 8343039: Remove jdk.internal.misc.InternalLock and usages from java.io [v9]

Brian Burkhalter bpb at openjdk.org
Fri Nov 15 01:35:44 UTC 2024


On Fri, 15 Nov 2024 01:20:43 GMT, Chen Liang <liach at openjdk.org> wrote:

> Looks good

Thanks, @liach , for the second review.

> src/java.base/share/classes/java/io/BufferedReader.java line 329:
> 
>> 327:             if (term != null) term[0] = false;
>> 328: 
>> 329:             bufferLoop:
> 
> How do we usually handle the indentation of labels?  I personally prefer this type of indentation, but in the jdk18 code the label has one less level of indentation, so it aligns with the enclosing `}`.  Don't know if we are looking for parity with 18 code.

I don't know what the indentation convention for labels is. Neither the draft style guide (https://cr.openjdk.org/~alundblad/styleguide/index-v6.html) nor the ancient code conventions from 1997 mention this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22048#issuecomment-2477770118
PR Review Comment: https://git.openjdk.org/jdk/pull/22048#discussion_r1843078969


More information about the core-libs-dev mailing list