RFR: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module [v2]

[Eirik Bjørsnøs]

On Fri, 15 Nov 2024 06:33:30 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Remove empty line in addProvides
>>  - Add full stop after class description for SystemImage
>
> src/java.base/share/classes/jdk/internal/module/Modules.java line 158:
> 
>> 156:         ClassLoader loader = m.getClassLoader();
>> 157: 
>> 158:         ClassLoader platformClassLoader = ClassLoaders.platformClassLoader();
> 
> You can remove the blank line at L157 now, it was only there to make the doPriv use clearer.

Removed blank line

> src/java.base/share/classes/jdk/internal/module/SystemModuleFinders.java line 364:
> 
>> 362: 
>> 363:     /**
>> 364:      * Holder class for the ImageReader
> 
> In passing, you would mind adding a full stop after ImageReader. Only noticed it with the removal of the apinote.

Added a full stop at the end of the SystemImage class description.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22113#discussion_r1843272795
PR Review Comment: https://git.openjdk.org/jdk/pull/22113#discussion_r1843273170