RFR: 8331497: Implement JEP 483: Ahead-of-Time Class Loading & Linking [v12]
John R Rose
jrose at openjdk.org
Fri Nov 15 07:19:52 UTC 2024
On Fri, 15 Nov 2024 05:48:27 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> This is an implementation of [JEP 483: Ahead-of-Time Class Loading & Linking](https://openjdk.org/jeps/483).
>>
>> ----
>> Note: this is a combined PR of the following individual PRs
>> - https://github.com/openjdk/jdk/pull/20516
>> - https://github.com/openjdk/jdk/pull/20517
>> - https://github.com/openjdk/jdk/pull/20843
>> - https://github.com/openjdk/jdk/pull/20958
>> - https://github.com/openjdk/jdk/pull/20959
>> - https://github.com/openjdk/jdk/pull/21049
>> - https://github.com/openjdk/jdk/pull/21143
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 179 commits:
>
> - Merge branch 'master' into jep-483-candidate
> - Merge branch 'master' into jep-483-candidate
> - fixed merge with UseCompactObjectHeaders
> - Merge branch 'master' into jep-483-candidate
> - fixed merge
> - Merge branch 'master' of https://github.com/openjdk/jdk into merge-mainline
> - @DanHeidinga comment -- exit VM when runtimeSetup() fails
> - fixed merge
> - Merge branch 'master' into jep-483-candidate
> - 8343493: Perform module checks during MetaspaceShared::map_archives()
> - ... and 169 more: https://git.openjdk.org/jdk/compare/db56266a...77b253cf
Re-reviewed. I compared the current diffs with the diffs from my last review.
All new changes look good.
Lilliput conflict resolution looks good. I assume we test that path.
Nice work.
One typo in `make/RunTests.gmk`:
> The AOT cache file to be usd to wun the test with
-------------
Marked as reviewed by jrose (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/21642#pullrequestreview-2437843167
More information about the core-libs-dev
mailing list