RFR: 8344231: SecurityManager cleanup in java.lang.module and jdk.internal.module [v2]

[Alan Bateman]

On Fri, 15 Nov 2024 07:01:39 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> Please review this PR which removes code depending on SecurityManager from the `java.lang.module` and `jdk.internal.module` packages:
>> 
>> * `ModuleFinder::ofSystem` is updated to not check the `"accessSystemModules"` RuntimePermission
>> * The `ModuleReferences.ExplodedModuleReader` constructor is updated to remove the check that the caller has access to the directory.
>> * `Modules::addProvides` is updated to not use `AccessController::doPrivileged` when getting the module class loader
>> * `SystemModuleFinder::ofSystem` is updated to not returned a wrapped result calling `AccessController::doPrivileged`
>> * `SystemModuleFinders.SystemImage` is updated to remove a class level comment referring to the SM
>> * `SystemModuleFinders.SystemModuleReader::checkPermissionToConnect` is removed. The URI constructor parameter in `SystemModuleReader` becomes unused and is removed.
>> 
>> 
>> Testing: I have run `test/jdk/java/lang/module`, `test/jdk/java/lang/ModuleTests`,  and `test/jdk/java/lang/ModuleLayer` successfully. GHA results pending.
>
> Eirik Bjørsnøs has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Remove empty line in addProvides
>  - Add full stop after class description for SystemImage

Marked as reviewed by alanb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/22113#pullrequestreview-2437846462