Integrated: 8344179: SecurityManager cleanup in the ZIP and JAR areas

Eirik Bjørsnøs eirbjo at openjdk.org
Fri Nov 15 07:51:50 UTC 2024


On Thu, 14 Nov 2024 10:18:18 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

> Please review this PR which cleans up security manager related code in `java.util.zip` and `java.util.jar`:
> 
> * `JarFile` and `ZipFile` are updated to use `System::getProperty` instead of `GetPropertyAction::privilegedGetProperty`
> *  `ZipFile` is updated to not call SM::checkRead, SM::checkDelete when opening files
> * `ZipOutputStream` is updated to use `Boolean::getBoolean` instead of `GetBooleanAction::privilegedGetProperty`
> 
> The field `ZipFile.startsWithLoc` is deliberately left alone, that should be handled separately. I found no SM-dependent code in the ZIP or JAR tests. 
> 
> Testing: This is a cleanup PR, no tests are changed or updated. ZIP and JAR tests run green locally. GHA results pending.

This pull request has now been integrated.

Changeset: 857f68c6
Author:    Eirik Bjørsnøs <eirbjo at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/857f68c60f9c82c38f3b3a83692477dfe50a6ea4
Stats:     17 lines in 3 files changed: 0 ins; 12 del; 5 mod

8344179: SecurityManager cleanup in the ZIP and JAR areas

Reviewed-by: lancea, rriggs, mullan, jpai

-------------

PR: https://git.openjdk.org/jdk/pull/22099


More information about the core-libs-dev mailing list