RFR: 8344289: SM cleanup in jdk.internal.util

Eirik Bjørsnøs eirbjo at openjdk.org
Fri Nov 15 09:46:59 UTC 2024


Please review this PR to clean up `RandomSupport`, `ClassFileDumper` and `StaticProperty` in the `jdk.internal.util` namespace:

* `RandomSupport` is updated to replace an `AccessController::doPrivileged` call with `Boolean::getBoolean`. (Existing code uses `String::equalsIgnoreCase`, equivalent to `Boolean::getBoolean`)
* `ClassFileDumper` constructor is updated to remove a comment referencing `GetPropertyAction`. (I left the `VM::getSavedProperty` call as-is, please advise if this should be replaced with `System::getProperty)
* `ClassFileDumper::write` is updated to unwrap a `AccessController::doPrivileged` call
* `StaticProperty` is updated to remove `SecurityManager::checkPropertyAccess` references in the documentation

Verification: GHA results pending.

-------------

Commit messages:
 - Clean up ClassFileDumper, RandomSupport and StaticProperty following JEP486 integration

Changes: https://git.openjdk.org/jdk/pull/22141/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22141&range=00
  Issue: https://bugs.openjdk.org/browse/JDK-8344289
  Stats: 116 lines in 3 files changed: 6 ins; 89 del; 21 mod
  Patch: https://git.openjdk.org/jdk/pull/22141.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22141/head:pull/22141

PR: https://git.openjdk.org/jdk/pull/22141


More information about the core-libs-dev mailing list