RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform
Taizo Kurashige
duke at openjdk.org
Fri Nov 15 09:47:57 UTC 2024
To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" executed with "chcp 65001". This ensures that the encoding is UTF8 and that the English message "No Instance(s) Available." is output on localized windows platforms.
I have referred to the following for how to use chcp:
・chcp | Microsoft Learn at https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
・Code Page Identifiers - Win32 apps | Microsoft Learn at https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019 (Japanese and English locales). I confirmed that they pass.
Thanks
-------------
Commit messages:
- Merge branch 'openjdk:master' into fix_Win8301247Test_bug
- Fix comment
- Merge branch 'openjdk:master' into fix_Win8301247Test_bug
- Insert newline
- Fix WindowsHelper.java
- Fix Win8301247Test bug
- Fix Win8301247Test bug
Changes: https://git.openjdk.org/jdk/pull/22142/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22142&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8344275
Stats: 37 lines in 2 files changed: 23 ins; 1 del; 13 mod
Patch: https://git.openjdk.org/jdk/pull/22142.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22142/head:pull/22142
PR: https://git.openjdk.org/jdk/pull/22142
More information about the core-libs-dev
mailing list