RFR: 8343704: Bad GC parallelism with processing Cleaner queues [v4]

Aleksey Shipilev shade at openjdk.org
Fri Nov 15 10:19:46 UTC 2024


On Fri, 15 Nov 2024 06:36:22 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>>> I see that existing `Cleaner` tests are quite rich already. 
>>> ...
>>> The new asserts around that code should IMO test enough with existing tests.
>> 
>> Should any of the existing `Cleaner` tests have `@run`s added with `-esa` ?
>
> RunTests.gmk adds -ea -esa so the testing is done with asserts enabled when using "make run-test".

So then adding `-ea -esa` is superfluous in the tests. I removed these from the test for extra cleanliness.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1843541711


More information about the core-libs-dev mailing list