RFR: 8343881: java.lang.classfile.Attribute attributeName() method should return Utf8Entry [v3]

Adam Sotona asotona at openjdk.org
Fri Nov 15 11:42:58 UTC 2024


On Thu, 14 Nov 2024 17:12:55 GMT, Adam Sotona <asotona at openjdk.org> wrote:

>> Class-File API usually expose names in a form of `java.lang.classfile.constantpool.Utf8Entry`. Unfortunately `java.lang.classfile.Attribute::attributeName` method was omitted during the API review and it returns inflated `String` value of the name.
>> 
>> This patch changes return type of `java.lang.classfile.Attribute::attributeName` from `String` to `java.lang.classfile.constantpool.Utf8Entry`.
>> 
>> Please review.
>> 
>> Thanks,
>> Adam
>
> Adam Sotona has updated the pull request incrementally with one additional commit since the last revision:
> 
>   more fixes

Thank you for the review!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22107#issuecomment-2478630042


More information about the core-libs-dev mailing list