RFR: 8344197: SM cleanup in java.util.concurrent

[Doug Lea]

On Fri, 15 Nov 2024 07:36:37 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Refactored to remove use of doPrivileged() and use of SecurityManager.
>> The DefaultForkJoinWorkerThreadFactory no longer uses the SM to target a common thread pool.
>> 
>> A careful review is requested.
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
> 
>> 1106:         implements ForkJoinWorkerThreadFactory {
>> 1107:         public final ForkJoinWorkerThread newThread(ForkJoinPool pool) {
>> 1108:             return new ForkJoinWorkerThread(null, pool, true, false);
> 
> This doesn't look right. For the common pool it should return InnocuousForkJoinWorkerThread(pool).

I agree on both counts with Alan: The FJP changes are not quite right, and in any case should be postponed until after current FJP PR, and then further simplified, which would be easiest if I did this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22119#discussion_r1843772670