RFR: 8344197: SM cleanup in java.util.concurrent [v2]

Roger Riggs rriggs at openjdk.org
Fri Nov 15 15:59:32 UTC 2024


On Fri, 15 Nov 2024 13:30:34 GMT, Doug Lea <dl at openjdk.org> wrote:

>> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 1108:
>> 
>>> 1106:         implements ForkJoinWorkerThreadFactory {
>>> 1107:         public final ForkJoinWorkerThread newThread(ForkJoinPool pool) {
>>> 1108:             return new ForkJoinWorkerThread(null, pool, true, false);
>> 
>> This doesn't look right. For the common pool it should return InnocuousForkJoinWorkerThread(pool).
>
> I agree on both counts with Alan: The FJP changes are not quite right, and in any case should be postponed until after current FJP PR, and then further simplified, which would be easiest if I did this.

@DougLea If you prefer, I can leave any/all changes to you.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22119#discussion_r1844096923


More information about the core-libs-dev mailing list