RFR: 8343876: Enhancements to jpackage test lib [v5]

[Alexander Matveev]

On Fri, 15 Nov 2024 14:53:18 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/TestMethodSupplier.java line 142:
>> 
>>> 140:                 throw ex;
>>> 141:             }
>>> 142:         }
>> 
>> Maybe move this code into `switch` statement under `default`? Also, should we use `TypeStatus.UNKNOWN` instead of `null`?
>
>> Maybe move this code into switch statement under default?
> 
> Can't use "null" in the switch.
> 
>> should we use TypeStatus.UNKNOWN instead of null?
> 
> To deal with `TypeStatus.UNKNOWN` and `null`? Besides of that what is the semantics of `TypeStatus.UNKNOWN`? 
> 
> - `TypeStatus.NOT_TEST_CLASS` is for types that are NOT test classes.
> - `TypeStatus.VALID_TEST_CLASS` is for types that are valid test classes.
> - `TypeStatus.TEST_CLASS` is for all other types, i.e. invalid test classes.
> 
> How does `TypeStatus.UNKNOWN` fit?

Never mind. I see why it is `null`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21996#discussion_r1844684516