RFR: 8344331: SM cleanup in java.scripting

Naoto Sato naoto at openjdk.org
Fri Nov 15 23:57:01 UTC 2024


On Fri, 15 Nov 2024 23:23:39 GMT, Justin Lu <jlu at openjdk.org> wrote:

> Please review this PR which removes the lone `AccessController.doPrivileged` call from the _java.scripting_ module after JEP486 integration.

Marked as reviewed by naoto (Reviewer).

src/java.scripting/share/classes/javax/script/ScriptEngineManager.java line 89:

> 87:         Iterator<ScriptEngineFactory> itr;
> 88:         try {
> 89:             var sl = getServiceLoader(loader);

Fine as it stands, but this var `sl` is no longer needed.

-------------

PR Review: https://git.openjdk.org/jdk/pull/22170#pullrequestreview-2439959722
PR Review Comment: https://git.openjdk.org/jdk/pull/22170#discussion_r1844689213


More information about the core-libs-dev mailing list