RFR: 8344168: Change Unsafe base offset from int to long

[Alan Bateman]

On Fri, 15 Nov 2024 01:05:10 GMT, ExE Boss <duke at openjdk.org> wrote:

>> Doesn't this break any apps that use these offsets?  Aren't these fields part of the public API of Unsafe, so changing them requires a CSR?
>
> @dean-long
>> Doesn't this break any apps that use these offsets? Aren't these fields part of the public API of Unsafe, so changing them requires a CSR?
> 
> This is the encapsulated JDK‑internal `Unsafe` in `java.base`, not the legacy `sun.misc.Unsafe`.

> @ExE-Boss , are you saying the CSR doesn't apply to jdk.internal.*? The CSR FAQ says: "Changes to public and exported APIs in jdk.*packages." Whether or not it needs a CSR, I think there are apps outside the JDK that will break because of this change.

jdk.internal.** is JDK internal, none of these packages are exported. It's okay to make changes in any release, any builds. Nothing outside of the JDK should be depending on internal APIs like this.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22095#issuecomment-2480480585