RFR: 8339480: Build static-jdk image with a statically linked launcher [v7]

[Magnus Ihse Bursie]

On Mon, 21 Oct 2024 13:07:34 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

>> src/java.base/unix/native/libjli/java_md.c line 279:
>> 
>>> 277:                            char jvmpath[], jint so_jvmpath,
>>> 278:                            char jvmcfg[],  jint so_jvmcfg) {
>>> 279:     /* Compute/set the name of the executable. This is needed for macOS. */
>> 
>> But this file is not used when on macOS, is it? (cfr java_md_macosx.m) )
>
> Hm. I think both are used? I'll need to double-check that.

You are right. Don't know how this got in here, I must have thought it needed at some point when trying to get this to work on macOS. 

This really is a sign that I've been doing cargo-cult programming. The entire JDK bootstrapping mechanism is so spread-out and difficult to follow that it ends up being more "poke a bit here and see if it works" kind of programming instead of understanding what needs to be done and doing it. We should really make a follow-up refactoring on this to get it to a better state, across all modules and components...

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1846348477