RFR: 8344337: SecurityManager cleanup in java.prefs moduleRemove SecMgr, etc usage from java.prefs

[Lance Andersen]

On Tue, 19 Nov 2024 18:52:59 GMT, Brent Christian <bchristi at openjdk.org> wrote:

> Remove usages of SecurityManager, doPrivildged, and AccessController from the java.prefs module.

Hi Brent,

There looks to be a lot of commented out code that should be removed as part of your PR?

src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 33:

> 31: //import java.security.PrivilegedAction;
> 32: //import java.security.PrivilegedExceptionAction;
> 33: import java.security.PrivilegedActionException;

I think you can remove these vs leaving them commented out

src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 63:

> 61: //        };
> 62: //        AccessController.doPrivileged(load);
> 63:     }

Looks like there is some clean up here to do of the commented out code...

-------------

Changes requested by lancea (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22252#pullrequestreview-2446445645
PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1848933440
PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1848935376