RFR: 8343704: Bad GC parallelism with processing Cleaner queues [v12]

Aleksey Shipilev shade at openjdk.org
Tue Nov 19 19:53:49 UTC 2024


On Tue, 19 Nov 2024 19:19:51 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 13 additional commits since the last revision:
>> 
>>  - Touchups
>>  - Merge branch 'master' into JDK-8343704-cleaner-gc
>>  - Drop --add-exports from the test
>>  - prev is not needed
>>  - Do not need -ea -esa in tests, our testing infra adds them already
>>  - Add the node cache
>>  - Avoid NPE on empty list, add tests, touchups
>>  - Reimplement with segmented linked list of arrays
>>  - Review feedback: make sure trimming actually works, stylistic changes
>>  - Merge branch 'master' into JDK-8343704-cleaner-gc
>>  - ... and 3 more: https://git.openjdk.org/jdk/compare/c5e55209...dc55597d
>
> test/jdk/jdk/internal/ref/Cleaner/CleanableListTest.java line 102:
> 
>> 100:         Assert.assertTrue(list.isEmpty());
>> 101: 
>> 102:         Random r = new Random(42);
> 
> If a constant random seed is used, the test will always run in the same way, yes?
> Also, consider using `jdk.test.lib.RandomFactory`.

Migrated to `RandomFactory` now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22043#discussion_r1848974469


More information about the core-libs-dev mailing list