RFR: 8342103: C2 compiler support for Float16 type and associated operations

Paul Sandoz psandoz at openjdk.org
Tue Nov 19 19:57:14 UTC 2024


On Fri, 25 Oct 2024 04:46:52 GMT, Jatin Bhateja <jbhateja at openjdk.org> wrote:

>> Hi Jatin, could you also include the idealization tests here - test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and ConvF2HFIdealizationTests.java in this PR?
>
>> Hi Jatin, could you also include the idealization tests here - test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java and ConvF2HFIdealizationTests.java in this PR?
> 
> Hi @Bhavana-Kilambi ,
> I am in process of refining existing patch, tests and benchmark, will update the PR.

@jatin-bhateja i commented directly on code in the commit entitled "Annotating Float16 as a ValueBased class" but i don't see it. This is not the right way to it, see my [comment](https://github.com/openjdk/jdk/pull/21574#discussion_r1841020576) related to this on Joe's FLoat16 PR. We should address it as a separate PR for ease of review.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21490#issuecomment-2476891427


More information about the core-libs-dev mailing list