RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows
Alexey Semenyuk
asemenyuk at openjdk.org
Tue Nov 19 20:24:59 UTC 2024
Fix `ResourceEditor` class to handle long paths.
Based on https://github.com/openjdk/jdk/pull/9384 PR.
This repairs app image building on Windows if the path to jpackage temp directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and can NOT be repaired due to WiX's limitations.
Repaired scenario when the `--dest` option references a long path on Windows. Previously jpackage would have failed to build MSI package.
Other changes:
- Rename `Executor.setRemovePath()` into `Executor.setRemovePathEnvVar()` to make the method name match the implementation.
- Move the mutable part of `WixPipeline` class into `WixPipeline.Builder` class.
- Fixed minor flaws in "WinL10nTest.java"
-------------
Commit messages:
- Merge branch 'master' into JDK-8289771
- Fix bad merge
- Use JDK21 Path.resolve()
- Fix bad merge
- Merge branch 'JDK-8344550' into JDK-8289771
- 8344550: Compilation error of jpackage test JPackageStringBundle.java source
- Copy transient msi file in "msi-copy" subdir of the test work dir instead of the test work dir.
- l10n bugfix
- Merge branch 'master' into JDK-8289771
- - Restored absolute paths in wix command lines.
- ... and 7 more: https://git.openjdk.org/jdk/compare/78602be1...eff5cf01
Changes: https://git.openjdk.org/jdk/pull/22092/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22092&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8289771
Stats: 512 lines in 18 files changed: 415 ins; 12 del; 85 mod
Patch: https://git.openjdk.org/jdk/pull/22092.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22092/head:pull/22092
PR: https://git.openjdk.org/jdk/pull/22092
More information about the core-libs-dev
mailing list