RFR: 8336707: Contention of ForkJoinPool grows when stealing works [v29]

Doug Lea dl at openjdk.org
Tue Nov 19 21:12:58 UTC 2024


On Tue, 19 Nov 2024 16:54:04 GMT, Viktor Klang <vklang at openjdk.org> wrote:

>> Doug Lea has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Ensure InnocuousForkJoinWorkerThread usable with or without SecurityManager
>
> src/java.base/share/classes/java/util/concurrent/ForkJoinPool.java line 2838:
> 
>> 2836:                         }
>> 2837:                     }
>> 2838:                     else if ((q.phase & (IDLE|1)) == 0 ||
> 
> @DougLea What's the intent of the `|1` part here? 🤔

clarified by:
                    else if ((q.phase & (IDLE|1)) == 0 || // externally locked

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21507#discussion_r1849059348


More information about the core-libs-dev mailing list