RFR: 8289771: jpackage: ResourceEditor error when path is overly long on Windows [v3]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Nov 20 03:01:28 UTC 2024


On Tue, 19 Nov 2024 23:55:33 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make path guaranteed to be long enough
>
> test/jdk/tools/jpackage/windows/WinLongPathTest.java line 38:
> 
>> 36: 
>> 37: /*
>> 38: /* @test
> 
> Extra `/`?

No, the leading `/*` is deliberate. I prefer it this way.

There is no consistency in formatting:

https://github.com/openjdk/jdk/blob/8a1f9f0a324e30b5da53d58434ac1b39569fc523/test/hotspot/jtreg/gc/ArraySize.java#L24

https://github.com/openjdk/jdk/blob/8a1f9f0a324e30b5da53d58434ac1b39569fc523/test/jdk/com/sun/jdi/InvokeVarArgs.java#L24

https://github.com/openjdk/jdk/blob/8a1f9f0a324e30b5da53d58434ac1b39569fc523/test/jdk/java/io/File/Mkdir.java#L24

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22092#discussion_r1849432814


More information about the core-libs-dev mailing list