RFR: 8341923: java.util.Locale class specification improvements [v3]

Justin Lu jlu at openjdk.org
Wed Nov 20 03:03:26 UTC 2024


On Tue, 19 Nov 2024 20:30:11 GMT, Naoto Sato <naoto at openjdk.org> wrote:

>> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address Naoto's comments
>
> src/java.base/share/classes/java/util/Locale.java line 144:
> 
>> 142:  *   each indicating its own semantics, these values should be ordered
>> 143:  *   by importance, with most important first, separated by
>> 144:  *   underscore('_').  The variant field is case sensitive.</dd>
> 
> This part "separated by underscore('_')" is missing in the revised doc

I intentionally omitted this because

- I thought it was redundant as the syntax already follows a few lines below.
- The `Locale` syntax allows both `_` and  `-`, not just `_`.

However, if you think it should remain, I'll restore it as `separated by ('_'|'-')`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22192#discussion_r1849432988


More information about the core-libs-dev mailing list