RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v3]

Wed Nov 20 04:14:16 UTC 2024

On Fri, 15 Nov 2024 13:25:01 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> The implementation may change, but the name of the function should remain the same.

That certainly makes sense. I changed setWinEnableUTF8 to setWinRunWithEnglishOutput as you suggested.

> I'd run suppress the output of "chcp" command: chcp 65001 >nul 2>&1. This will make its usage transparent for the clients of the "Executor" class.

That's true. I added `> nul2 > & 1` to suppress output of "chcp" command.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1849480383
PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1849480236