RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v3]

Taizo Kurashige duke at openjdk.org
Wed Nov 20 04:25:15 UTC 2024


On Wed, 20 Nov 2024 03:13:23 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Taizo Kurashige has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix indent
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/Executor.java line 487:
> 
>> 485:                 List::stream).toList();
>> 486: 
>> 487:         return String.format(format, printCommandLine(cmdline), cmdline.size() + 1);
> 
> `cmdline.size() + 1` seems to be wrong. It should be `cmdline.size()`.
>  ` + 1` was needed previously when was applied to the `args.size()` that didn't count the executable. Sorry, I oversaw this thing in my patch.

Thanks, I understood why `+ 1` is not needed. I removed `+ 1`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22142#discussion_r1849494766


More information about the core-libs-dev mailing list