RFR: 8341402: BigDecimal's square root optimization [v20]

[Raffaello Giulietti]

On Tue, 19 Nov 2024 18:44:51 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Correct remainder checking
>
> src/java.base/share/classes/java/math/BigDecimal.java line 2260:
> 
>> 2258:                     }
>> 2259: 
>> 2260:                     default -> throw new AssertionError("Unexpected value for RoundingMode: " + mc.roundingMode);
> 
> I think `MatchException` might be better suited (with a `null` cause), but I'll crosscheck and let you know tomorrow.

You can leave `AssertionError` as it is.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21301#discussion_r1850215392