RFR: 8344223: Remove calls to SecurityManager and doPrivileged in java.net.URLClassLoader after JEP 486 integration [v4]
Daniel Fuchs
dfuchs at openjdk.org
Wed Nov 20 12:38:17 UTC 2024
On Wed, 20 Nov 2024 06:52:11 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:
>> Can I please get a review of this change which proposes to remove SecurityManager related API usages from `URLClassLoader` and its related `URLClassPath`? This addresses https://bugs.openjdk.org/browse/JDK-8344223.
>>
>> The `URLClassLoader.getPermissions()` method will need additional changes but that will be done as part of https://bugs.openjdk.org/browse/JDK-8343150.
>>
>> I'll be opening a CSR for this change because we are removing support for the `jdk.net.URLClassPath.disableRestrictedPermissions` system property.
>>
>> No new tests have been added and existing tier1, tier2 and tier3 tests continue to pass.
>
> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - merge latest from master branch
> - Alan's review - fix code comment
> - merge latest from master branch
> - 8344223: Remove calls to SecurityManager and doPrivileged in java.net.URLClassLoader after JEP 486 integration
Not an expert here but those changes look good to me. It's good to see all this complicated code go away!
-------------
PR Review: https://git.openjdk.org/jdk/pull/22233#pullrequestreview-2448502485
More information about the core-libs-dev
mailing list