RFR: 8338536: Permanently disable remote code downloading in JNDI [v5]
Daniel Fuchs
dfuchs at openjdk.org
Wed Nov 20 16:46:24 UTC 2024
On Wed, 20 Nov 2024 16:40:43 GMT, Aleksei Efimov <aefimov at openjdk.org> wrote:
>> src/jdk.naming.rmi/share/classes/module-info.java line 64:
>>
>>> 62: * location} specified in the reference can be supported by a custom implementation of {@link
>>> 63: * javax.naming.spi.ObjectFactoryBuilder}. If a location is specified, then
>>> 64: * unless an {@link javax.naming.spi.ObjectFactoryBuilder} is installed a
>>
>> Minor: I think you need:
>>
>> unless an {@link javax.naming.spi.ObjectFactoryBuilder ObjectFactoryBuilder}
>>
>> to avoid the uncertainty about whether this would be rendered as "an javax...." or "an Object..."
>
> I've checked the generated javadoc, and the link is rendered as:
> "If a location is specified, then unless an _ObjectFactoryBuilder_"
Good, thanks for double checking :-)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22154#discussion_r1850659717
More information about the core-libs-dev
mailing list