Integrated: 8289771: jpackage: ResourceEditor error when path is overly long on Windows

Alexey Semenyuk asemenyuk at openjdk.org
Wed Nov 20 16:57:27 UTC 2024


On Thu, 14 Nov 2024 04:40:37 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Fix `ResourceEditor` class to handle long paths.
> 
> Based on https://github.com/openjdk/jdk/pull/9384 PR.
> 
> This repairs app image building on Windows if the path to jpackage temp directory exceeds 260 (`MAX_PATH`) characters. MSI building is still broken and can NOT be repaired due to WiX's limitations.
> 
> Repaired scenario when the `--dest` option references a long path on Windows. Previously jpackage would have failed to build MSI package.
> 
> Other changes:
>  - Rename `Executor.setRemovePath()` into `Executor.setRemovePathEnvVar()` to make the method name match the implementation.
>  - Move the mutable part of `WixPipeline` class into `WixPipeline.Builder` class.
>  - Fixed minor flaws in "WinL10nTest.java"

This pull request has now been integrated.

Changeset: 080f1cc8
Author:    Alexey Semenyuk <asemenyuk at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/080f1cc8cd0500c254debec3198dc187bd41c3e8
Stats:     512 lines in 18 files changed: 415 ins; 12 del; 85 mod

8289771: jpackage: ResourceEditor error when path is overly long on Windows

Reviewed-by: almatvee

-------------

PR: https://git.openjdk.org/jdk/pull/22092


More information about the core-libs-dev mailing list