RFR: 8344337: SecurityManager cleanup in java.prefs module [v4]

[Brian Burkhalter]

On Wed, 20 Nov 2024 18:03:53 GMT, Brent Christian <bchristi at openjdk.org> wrote:

>> Remove usages of SecurityManager, doPrivildged, and AccessController from the java.prefs module.
>
> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix indentation, add braces

src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 127:

> 125:                 getLogger().info("Created user preferences directory.");
> 126:             }
> 127:             else

It seems odd that `else` is not on line 126 after the bracket. If putting it on the same line makes it  less readable, then maybe add a pair of brackets for the `else`.

src/java.prefs/unix/classes/java/util/prefs/FileSystemPreferences.java line 586:

> 584:                 m = new TreeMap<>();
> 585:             } else if (e instanceof FileNotFoundException) {
> 586:             getLogger().warning("Prefs file removed in background "

This could be indented.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1850819795
PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1850816922