RFR: 8344275: tools/jpackage/windows/Win8301247Test.java fails on localized Windows platform [v5]

[Alexander Matveev]

On Thu, 21 Nov 2024 04:32:50 GMT, Taizo Kurashige <duke at openjdk.org> wrote:

>> To resolve tools/jpackage/windows/Win8301247Test.java failure, I made "wmic" executed with "chcp 437". This ensures that the English message "No Instance(s) Available." is output on localized windows platforms.
>> 
>> I have referred to the following for how to use chcp:
>> ・chcp | Microsoft Learn at https://learn.microsoft.com/en-us/windows-server/administration/windows-commands/chcp
>> ・Code Page Identifiers - Win32 apps | Microsoft Learn at https://learn.microsoft.com/en-us/windows/win32/intl/code-page-identifiers
>> 
>> After fix, I ran tools/jpackage tests importing jdk.jpackage.test.Executor or jdk.jpackage.test.WindowsHelper.killAppLauncherProcess on Windows Server 2019 (Japanese and English locales). I confirmed that they pass.
>> 
>> Thanks
>
> Taizo Kurashige has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
> 
>  - Fix conflict
>  - Fix about size of cmdline
>  - Fix indent
>  - Merge branch 'fix_Win8301247Test_bug' of https://github.com/kurashige23/jdk into fix_Win8301247Test_bug
>  - Merge branch 'openjdk:master' into fix_Win8301247Test_bug
>  - Chenge code page from 65001 to 437
>  - Fix how to execute chcp command
>  - Change setWinEnableUTF8 to setWinRunWithEnglishOutput
>  - Suppress the output of chcp command
>  - Fix comment
>  - ... and 5 more: https://git.openjdk.org/jdk/compare/a01aa220...f013d9fb

Looks good.

-------------

Marked as reviewed by almatvee (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22142#pullrequestreview-2452884938