RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v7]

Jaikiran Pai jpai at openjdk.org
Fri Nov 22 04:43:56 UTC 2024


On Tue, 19 Nov 2024 19:27:39 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   missed a few methods for specifying IllegalStateException
>
> src/java.base/share/classes/java/util/zip/Deflater.java line 892:
> 
>> 890:      * and discards any unprocessed input.
>> 891:      * <p>
>> 892:      * If this method is invoked multiple times, the subsequent calls are treated as a no-op.
> 
> I would say,
> 
>> If this method is invoked multiple times, the second and subsequent calls do nothing.

Done. I've updated the end() method's javadoc of both `Deflater` and `Inflater` to use this recommended text.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19675#discussion_r1853272941


More information about the core-libs-dev mailing list