RFR: 8344319: SM cleanup in jdk.dynalink module [v2]

[Attila Szegedi]

On Mon, 18 Nov 2024 16:13:27 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> Refactor to remove use of SecurityManager
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply review comments:
>   Retain public static constants for permission names to avoid source/binary compatible changes that affect cross version use.
>   Remove obsolete mention of security considerations.
>   (The protected constructor is retained to avoid changing the access for subclass use)

Thanks for making the changes! I'm approving it as-is, I have a small nit with an `@apiNote` but it's no big deal. Apologies for slow review, I had a rather busy work trip last week.

src/jdk.dynalink/share/classes/jdk/dynalink/SecureLookupSupplier.java line 46:

> 44:      * {@link #getLookup()} method.
> 45:      */
> 46:     public static final String GET_LOOKUP_PERMISSION_NAME = "dynalink.getLookup";

`AUTOLOAD_PERMISSION_NAME` below has an `@apiNote` that would be worth replicating here as well.

-------------

Marked as reviewed by attila (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/22152#pullrequestreview-2456704946
PR Review Comment: https://git.openjdk.org/jdk/pull/22152#discussion_r1855443551