RFR: 8343427: Class file load hook crashes on archived classes from multi-release JARs [v2]

Ioi Lam iklam at openjdk.org
Mon Nov 25 04:32:22 UTC 2024


On Thu, 21 Nov 2024 23:11:40 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> I think the concern may be that we want to avoid license headers.
>> 
>> However, we should still use text blocks instead of these string arrays for such inlined source files.
>
> I've changed the code to use text blocks.

We have two versions of the "Foo" class, but jtreg doesn't support building of classes with the same name. If you look at other multi-release JAR test cases, they all have to build the classes by hand. Embedded the Java sources in the test case is actually simpler than these existing tests:

- https://github.com/openjdk/jdk/blob/6f622da7fbae67d8c1cd9e795127adac58a246a9/test/jdk/tools/jar/multiRelease/MRTestBase.java
- https://github.com/openjdk/jdk/blob/6f622da7fbae67d8c1cd9e795127adac58a246a9/test/jdk/tools/jar/multiRelease/Basic.java

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22262#discussion_r1855784099


More information about the core-libs-dev mailing list