RFR: 8344908: URLClassPath should not propagate IllegalArgumentException when finding resources in classpath URLs [v2]

Jaikiran Pai jpai at openjdk.org
Mon Nov 25 08:14:16 UTC 2024


On Mon, 25 Nov 2024 08:08:18 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   minor code comment update in the test
>
> src/java.base/share/classes/sun/net/www/ParseUtil.java line 176:
> 
>> 174:      * @throws IllegalArgumentException if {@code s} could not be decoded
>> 175:      */
>> 176:     public static String decode(String s) throws IllegalArgumentException {
> 
> I'm not sure if you meant to add this or not but "throws IAE" is not needed, usually don't put unchecked exceptions in the throws.

Hello Alan, that was intentional to be more prominently visible, but I'll remove it and will just retain `@throws` javadoc tag that I added as part of this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22351#discussion_r1856038067


More information about the core-libs-dev mailing list