RFR: 8344319: SM cleanup in jdk.dynalink module [v2]

[Attila Szegedi]

On Sun, 24 Nov 2024 12:51:28 GMT, Attila Szegedi <attila at openjdk.org> wrote:

>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply review comments:
>>   Retain public static constants for permission names to avoid source/binary compatible changes that affect cross version use.
>>   Remove obsolete mention of security considerations.
>>   (The protected constructor is retained to avoid changing the access for subclass use)
>
> src/jdk.dynalink/share/classes/jdk/dynalink/SecureLookupSupplier.java line 46:
> 
>> 44:      * {@link #getLookup()} method.
>> 45:      */
>> 46:     public static final String GET_LOOKUP_PERMISSION_NAME = "dynalink.getLookup";
> 
> `AUTOLOAD_PERMISSION_NAME` below has an `@apiNote` that would be worth replicating here as well.

As @AlanBateman pointed out, the class has an API note so the member doesn't need one separately.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22152#discussion_r1856351167