RFR: 8344337: SecurityManager cleanup in java.prefs module [v6]

[Brent Christian]

On Mon, 25 Nov 2024 19:11:02 GMT, Iris Clark <iris at openjdk.org> wrote:

>> Brent Christian has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   spacing changes
>
> src/java.prefs/macosx/classes/java/util/prefs/MacOSXPreferencesFile.java line 87:
> 
>> 85:     @SuppressWarnings("restricted")
>> 86:     private static void loadPrefsLib() {
>> 87:         System.loadLibrary("prefs");
> 
> What am I missing?  Why keep the private static method if it only contains a single method invocation and is only used in the static initializer?

We want to `@SuppressWarnings("restricted")` the `loadLibrary()` call. IIUC, I can't `@SuppressWarnings` the static block, nor the call to `loadLibrary()`, so AFAICT that call needs to be in a separate, `@SuppressWarnings`-ed method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22252#discussion_r1857334730