RFR: 8225763: Inflater and Deflater should implement AutoCloseable [v5]

Lance Andersen lancea at openjdk.org
Tue Nov 26 11:54:42 UTC 2024


On Tue, 19 Nov 2024 19:28:50 GMT, Stuart Marks <smarks at openjdk.org> wrote:

>> Thank you.  It was an oversight that the original javadoc did not call out the NPE, but now is our chance to get it right with a more reasonable exception.
>
> Overall I agree with defining that IllegalStateException is thrown after the Deflater is closed, and adding documentation of this to all the methods that throw it.

I am no sure the last sentence, “several…” is needed here given we now document the IAE is thrown

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19675#discussion_r1858332913


More information about the core-libs-dev mailing list