RFR: 8339480: Build static-jdk image with a statically linked launcher [v17]
Magnus Ihse Bursie
ihse at openjdk.org
Tue Nov 26 15:42:55 UTC 2024
On Tue, 19 Nov 2024 20:34:31 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Copy debuginfo
>
> make/modules/java.desktop/lib/ClientLibraries.gmk line 166:
>
>> 164: jfdctflt.o jfdctfst.o jfdctint.o jidctflt.o jidctfst.o jidctint.o \
>> 165: jidctred.o jmemmgr.o jmemnobs.o jpegdecoder.o jquant1.o jquant2.o \
>> 166: jutils.o
>
> If libsplashscreen is already excluded in StaticLibs.gmk, why do we need to exclude obj files here?
>
> Would it be possible to generate this list? I assume it's all the src files in libjavajpeg, but with the object file suffix.
It's only excluded on Linux and Windows. (And that is just a silly one function with a duplicated name, that we could easily fix)
It's all src files from libjavajpeg that originates from upstream, but we add in some additional files. But if you prefer I can rewrite this as a wildcard for libjavajpeg and then filter out our files. (And replace the file suffix, of course.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20837#discussion_r1858776734
More information about the core-libs-dev
mailing list