RFR: 8341402: BigDecimal's square root optimization [v23]

fabioromano1 duke at openjdk.org
Tue Nov 26 17:30:41 UTC 2024


On Tue, 26 Nov 2024 17:22:41 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:

> I don't get your point. Here's an example:
> 
> ```
> BigDecimal.ONE.sqrt(new MathContext(2_000_000_000, RoundingMode.UP))
> |  Exception java.lang.ArithmeticException: Overflow
> |        at BigDecimal.sqrt (BigDecimal.java:2226)
> |        at (#4:1)
> ```

Yes, that's correct indeed, I was wrongly assuming that `this.precision() >= minWorkingPrec`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21301#discussion_r1858964273


More information about the core-libs-dev mailing list