RFR: 8344168: Change Unsafe base offset from int to long [v3]

Shaojin Wen swen at openjdk.org
Tue Nov 26 17:47:07 UTC 2024


> The type of the Unsafe base offset constant is int, which may cause overflow when adding int offsets, such as 8343925 (PR #22012). 8343984 (PR #22027) fixes most of the offset overflows in JDK, but ArraysSupport and CRC32C are still unfixed.
> 
> @liach proposed the idea of ​​changing the Unsafe base offset to long, which is a complete solution to the Unsafe offset overflow. After discussing with @liach, I submitted this PR to implement @liach's idea.

Shaojin Wen has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge remote-tracking branch 'upstream/master' into long_unsafe_offset_202411
 - long BaseAndScale base, from @JornVernee
 - long Unsafe offset

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22095/files
  - new: https://git.openjdk.org/jdk/pull/22095/files/f33e9d3d..cb8487dd

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22095&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22095&range=01-02

  Stats: 119439 lines in 2036 files changed: 58318 ins; 51793 del; 9328 mod
  Patch: https://git.openjdk.org/jdk/pull/22095.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22095/head:pull/22095

PR: https://git.openjdk.org/jdk/pull/22095


More information about the core-libs-dev mailing list