RFR: 8310691: [REDO] [vectorapi] Refactor VectorShuffle implementation [v2]

Quan Anh Mai qamai at openjdk.org
Tue Nov 26 18:20:24 UTC 2024


On Tue, 15 Oct 2024 16:25:04 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> Quan Anh Mai has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
>> 
>>   [vectorapi] Refactor VectorShuffle implementation
>
> src/hotspot/share/opto/vectornode.hpp line 1618:
> 
>> 1616:  public:
>> 1617:   VectorLoadShuffleNode(Node* in, const TypeVect* vt)
>> 1618:     : VectorNode(in, vt) {}
> 
> Can you add a comment above "class VectorLoadShuffleNode" to say what its semantics are?

Done, I would refrain from renaming it right now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21042#discussion_r1859030030


More information about the core-libs-dev mailing list