RFR: 8035271: Incorrect indentation of LineNumberTable/LocalVariableTable/Exception table/LocalVariableTypeTable/StackMapTable/RuntimeVisibleTypeAnnotations in verbose mode

[Jonathan Lampérth]

On Wed, 27 Nov 2024 10:14:11 GMT, Maurizio Cimadamore <mcimadamore at openjdk.org> wrote:

> Something like this, yeah, if this is deemed useful

I did implement this locally, but I am not sure of its utility. The values in `LineNumberTable` refer to PC locations, for which the number of opcodes does not really provide much context. What do you think?

> Or, if code is skipped, should we also skip code attributes?

I tend to like this approach, especially if I were starting from scratch. But considering the current functionality may be depended on, I think the current solution is a decent trade off of increasing readability/uniformity, without removing this existing functionality.

> For the records, I'm fine for these issues to be tackled also in separate PRs.

In that case I would suggest integrating as is. I would personally tend towards no further changes thereafter, but would be interested any other opinions/suggestions to the contrary.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22359#issuecomment-2503700433