RFR: 8343703: Symbol name cleanups after JEP 479 [v2]
Alex Menkov
amenkov at openjdk.org
Wed Nov 27 18:57:37 UTC 2024
On Wed, 27 Nov 2024 05:20:16 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was integrated, the handling of certain symbol lookup code can be simplified. The old code needed to support 32-bit Windows, where names had a trailing `@<number>`. When this special case now is removed, some streamlining is possible. Specifically these arrays:
>>
>> #define JNI_ONLOAD_SYMBOLS {"JNI_OnLoad"}
>> #define JNI_ONUNLOAD_SYMBOLS {"JNI_OnUnload"}
>> #define JVM_ONLOAD_SYMBOLS {"JVM_OnLoad"}
>> #define AGENT_ONLOAD_SYMBOLS {"Agent_OnLoad"}
>> #define AGENT_ONUNLOAD_SYMBOLS {"Agent_OnUnload"}
>> #define AGENT_ONATTACH_SYMBOLS {"Agent_OnAttach"}
>>
>> are all singletons and so the actual strings can just be inlined directly into the code that uses them.
>>
>> Testing:
>> - GHA
>> - Tiers 1-4 sanity
>> -
>> Thanks
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Update src/java.base/share/native/libjava/NativeLibraries.c
>
> Co-authored-by: Alex Menkov <69548902+alexmenkov at users.noreply.github.com>
Marked as reviewed by amenkov (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/22380#pullrequestreview-2465773079
More information about the core-libs-dev
mailing list