Integrated: 8343703: Symbol name cleanups after JEP 479

David Holmes dholmes at openjdk.org
Thu Nov 28 02:27:47 UTC 2024


On Tue, 26 Nov 2024 06:36:44 GMT, David Holmes <dholmes at openjdk.org> wrote:

> After JEP 479 ([JDK-8339783](https://bugs.openjdk.org/browse/JDK-8339783) was integrated, the handling of certain symbol lookup code can be simplified. The old code needed to support 32-bit Windows, where names had a trailing `@<number>`. When this special case now is removed, some streamlining is possible. Specifically these arrays:
> 
> #define JNI_ONLOAD_SYMBOLS {"JNI_OnLoad"}
> #define JNI_ONUNLOAD_SYMBOLS {"JNI_OnUnload"}
> #define JVM_ONLOAD_SYMBOLS {"JVM_OnLoad"}
> #define AGENT_ONLOAD_SYMBOLS {"Agent_OnLoad"}
> #define AGENT_ONUNLOAD_SYMBOLS {"Agent_OnUnload"}
> #define AGENT_ONATTACH_SYMBOLS {"Agent_OnAttach"}
> 
> are all singletons and so the actual strings can just be inlined directly into the code that uses them.
> 
> Testing:
> - GHA
> - Tiers 1-4 sanity
> - 
> Thanks

This pull request has now been integrated.

Changeset: 1a07d542
Author:    David Holmes <dholmes at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/1a07d542ec810282eb78653698d098a24b35686f
Stats:     95 lines in 5 files changed: 7 ins; 49 del; 39 mod

8343703: Symbol name cleanups after JEP 479

Reviewed-by: kbarrett, amenkov

-------------

PR: https://git.openjdk.org/jdk/pull/22380


More information about the core-libs-dev mailing list